Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for running scripts as backfill job #253

Merged
merged 2 commits into from
Feb 5, 2020
Merged

feat: add support for running scripts as backfill job #253

merged 2 commits into from
Feb 5, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 29, 2020

This allows us to run a script as a long running backfill operation, which is necessary to workaround the time limits in cloud functions.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
@bcoe bcoe requested review from JustinBeckwith and sofisl January 29, 2020 21:25
JustinBeckwith
JustinBeckwith approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of good stuff :)

@bcoe bcoe force-pushed the support-backfill branch 2 times, most recently from f80235f to 3a8ed78 Compare January 30, 2020 23:06
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2020
@bcoe bcoe force-pushed the support-backfill branch from 3a8ed78 to d582cb3 Compare February 4, 2020 21:45
@bcoe bcoe force-pushed the support-backfill branch from d582cb3 to 6f6a33e Compare February 5, 2020 00:08
@bcoe bcoe merged commit 26d54de into master Feb 5, 2020
@bcoe bcoe deleted the support-backfill branch February 5, 2020 19:30
This was referenced Feb 25, 2020
Closed
Closed
Closed
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
chore: pin @octokit/rest (#253)
8d2f081 
26d54de
commit 26d54de
Author: Benjamin E. Coe <[email protected]>
Date:   Wed Feb 5 11:30:38 2020 -0800

    chore: pin @octokit/rest (#253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcoe @JustinBeckwith @sofisl @googlebot @yoshi-kokoro