Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives for "Too many OwlBot updates created in a row" #3196

Closed
SurferJeffAtGoogle opened this issue Feb 16, 2022 · 3 comments · Fixed by #3199
Closed

False positives for "Too many OwlBot updates created in a row" #3196

SurferJeffAtGoogle opened this issue Feb 16, 2022 · 3 comments · Fixed by #3199
Assignees
@bcoe
Labels
bot: owl-bot priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@SurferJeffAtGoogle
Copy link
Contributor

Now that Owl Bot creates additional commits to open PRs, it will generate more commits in a row. It's working as intended and the post processor shouldn't refuse to run.

Example: googleapis/nodejs-document-ai#310
@SurferJeffAtGoogle SurferJeffAtGoogle added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. bot: owl-bot labels Feb 16, 2022
@SurferJeffAtGoogle
Copy link
Contributor Author

The strategy we discussed today of examining the title may not work. When we saw the infinite loop, wasn't it two bots flip flipping?

@SurferJeffAtGoogle
Copy link
Contributor Author

I found the original fix for the infinite loop, but I haven't found a bug report.
#1496

@bcoe
Copy link
Contributor

bcoe commented Feb 17, 2022

The bug that came up motivating the circuit-breaker was a bad Java image which flip flopped the date, history would be in synthtool repo.

bcoe added a commit that referenced this issue Feb 17, 2022
@bcoe
fix(owlbot): only short-circuit post-processor
72b0d43 
Rather than short-circuiting any updates from OwlBot, we now
check the commit message to see if it's from post-processor.

This should give us the same short-circuiting behavior, while
still running post-processor on PRs that have multiple pushes
from owl-bot copy code.

Fixes #3196
@bcoe bcoe mentioned this issue Feb 17, 2022
Merged
@chingor13 chingor13 mentioned this issue Feb 17, 2022
Merged
1 task
bcoe added a commit that referenced this issue Feb 18, 2022
@bcoe
fix(owlbot): only short-circuit post-processor (#3199)
6238128 
* fix(owlbot): only short-circuit post-processor

Rather than short-circuiting any updates from OwlBot, we now
check the commit message to see if it's from post-processor.

This should give us the same short-circuiting behavior, while
still running post-processor on PRs that have multiple pushes
from owl-bot copy code.

Fixes #3196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcoe bcoe

Labels
bot: owl-bot priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(owlbot): only short-circuit post-processor googleapis/repo-automation-bots
2 participants
@bcoe @SurferJeffAtGoogle