Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(snippet-bot): reduce memory footprint for large diffs #1143

Closed
tmatsuo opened this issue Nov 17, 2020 · 0 comments · Fixed by #1144
Closed

bug(snippet-bot): reduce memory footprint for large diffs #1143

tmatsuo opened this issue Nov 17, 2020 · 0 comments · Fixed by #1144
Assignees
@tmatsuo
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Nov 17, 2020

Related to #1134

Before we increase the memory limit to 1GB from 500MB, the bot died for 2 PRs with large diffs (75MB and 180MB). The bot create a string in an early stage, then passes that large string to parseRegionTagsInPullRequest. This creates adiitional copy of the string.

I think we should reduce at least one copy of this string instance.
@tmatsuo tmatsuo self-assigned this Nov 17, 2020
@JustinBeckwith JustinBeckwith added the type: cleanup An internal cleanup or hygiene concern. label Nov 17, 2020
tmatsuo pushed a commit to tmatsuo/repo-automation-bots that referenced this issue Nov 17, 2020
cleanup(snippet-bot): reduce memory footprint for large diffs
662b355 
fixes googleapis#1143
@tmatsuo tmatsuo mentioned this issue Nov 17, 2020
Merged
tmatsuo pushed a commit to tmatsuo/repo-automation-bots that referenced this issue Nov 17, 2020
cleanup(snippet-bot): reduce memory footprint for large diffs
163533b 
fixes googleapis#1143
tmatsuo pushed a commit that referenced this issue Nov 17, 2020
@bcoe
cleanup(snippet-bot): reduce memory footprint for large diffs (#1144)
03cf910 
* cleanup(snippet-bot): reduce memory footprint for large diffs

fixes #1143

* refactor a bit more

Co-authored-by: Benjamin E. Coe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatsuo tmatsuo

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup(snippet-bot): reduce memory footprint for large diffs tmatsuo/repo-automation-bots
2 participants
@tmatsuo @JustinBeckwith