fix(manifest): do not group changes under "." #841
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 64 64
Lines 9156 9160 +4
Branches 930 983 +53
=======================================
+ Hits 8583 8587 +4
Misses 570 570
Partials 3 3
Continue to review full report at Codecov.
|
| pkgName = this.packagePaths.find(p => { | ||
| // The special "." path, representing the root of the module | ||
| // should be ignored by commit-split: | ||
| return file.indexOf(p) >= 0 && p !== '.'; |
There was a problem hiding this comment.
hm, it seems like the '.' packagePath will never get any commits unless I'm reading this wrong? how will it get changelog entries and version bumps?
There was a problem hiding this comment.
but it seems to work. I confess I don't feel like I totally understand really how we're assigning commits to packages. I have a case were a commit got assigned to a package but none of the files for the commit are in the package path... and now that I wrote that I know exactly what happened in my case:
package path: "python"
commit files all under "examples/python/..."
but "examples/python/foo.py".indexOf("python") >= 0 is true! I think we want a stricter check here? probably
return file.indexOf(p) === 0 && p !== '.';
I'll submit a patch for this bug, but I still don't understand how the "." package is being assign the appropriate commits as it seems to be...
There was a problem hiding this comment.
the '.' packagePath will never get any commits unless I'm reading this wrong?
ok, I remember now: you're giving the '.' package its commits in manifest.ts rather than in here.
If "." was anything but the last path in the list, it would result in only receiving changes for the special "." path.