fix: do not change format of Python version files #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 62 62
Lines 8165 8165
Branches 810 810
=======================================
Hits 7455 7455
Misses 707 707
Partials 3 3
Continue to review full report at Codecov.
|
joeldodge79
reviewed
Feb 19, 2021
| @@ -12,4 +12,4 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| __version__ = "0.5.0" | |||
| __version__ = '0.5.0' | |||
There was a problem hiding this comment.
why did this and the snapshot need to change? in any case I think black uses "?
There was a problem hiding this comment.
I changed this to have at least one test that would not pass before the fix.
I don't know why the snapshot needed to change. I guess whatever files are involved in it had a different formatting
| /version ?= ?[0-9]+\.[0-9]+\.[0-9](-\w+)?/, | ||
| `version = ${this.version}` | ||
| /(version ?= ?)[0-9]+\.[0-9]+\.[0-9](?:-\w+)?/, | ||
| `$1${this.version}` |
bcoe
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #777