Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monorepo): remove package scope before matching merged PR #678

Closed
wants to merge 2 commits into from
Closed

fix(monorepo): remove package scope before matching merged PR #678

wants to merge 2 commits into from

Conversation

erezrokah
Copy link
Contributor

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #668 🦕

This is an attempt to reduce the scope of #669 to make it easier to review and publish a fix to a blocking bug (happy to close this one if #669 is close to being merged).
I think we should be able to add the logic to infer packageName in another PR (for me the priority for that fix is lower as there is a workaround of specifying it).

@erezrokah erezrokah requested a review from a team as a code owner January 3, 2021 19:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 3, 2021
@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #678 (33e8dc1) into master (243d6d9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   84.13%   84.19%   +0.05%     
==========================================
  Files          45       46       +1     
  Lines        5277     5295      +18     
  Branches      437      438       +1     
==========================================
+ Hits         4440     4458      +18     
  Misses        836      836              
  Partials        1        1              
Impacted Files Coverage Δ
src/github.ts 83.02% <100.00%> (+0.01%) ⬆️
src/release-pr.ts 89.09% <100.00%> (-0.10%) ⬇️
src/util/branch-prefix.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243d6d9...33e8dc1. Read the comment docs.

@bcoe
Copy link
Contributor

bcoe commented Jan 6, 2021

@erezrokah just reached out to @joeldodge79, I'd like to try to get #669 merged and tested ASAP; so if it would solve the same set of issues for you, perhaps we can run with it?

Let's keep this open until that time?

@erezrokah
Copy link
Contributor Author

@erezrokah just reached out to @joeldodge79, I'd like to try to get #669 merged and tested ASAP; so if it would solve the same set of issues for you, perhaps we can run with it?

Let's keep this open until that time?

Of course, completely agree with whatever you think is the best way to move forward

@erezrokah
Copy link
Contributor Author

Closing in favor of #669

@erezrokah erezrokah closed this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-release node monorepo package: no recent release PRs found
2 participants