Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yoshi-go): store the sha of the first commit #523

Merged
merged 3 commits into from
Aug 18, 2020
Merged

fix(yoshi-go): store the sha of the first commit #523

merged 3 commits into from
Aug 18, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 17, 2020

If the first commit was of the all type, we were setting its sha to null, this meant we had no sha to base a commit on.

@bcoe bcoe requested a review from a team as a code owner August 17, 2020 16:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2020
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #523 into master will decrease coverage by 0.44%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   81.67%   81.23%   -0.45%     
==========================================
  Files          42       42              
  Lines        4977     4993      +16     
  Branches      401      406       +5     
==========================================
- Hits         4065     4056       -9     
- Misses        911      935      +24     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/releasers/go-yoshi.ts 93.60% <96.15%> (-0.63%) ⬇️
src/util/coerce-option.ts 96.66% <0.00%> (-3.34%) ⬇️
src/github.ts 75.00% <0.00%> (-1.34%) ⬇️
src/conventional-commits.ts 97.15% <0.00%> (-1.22%) ⬇️
src/graphql-to-commits.ts 89.34% <0.00%> (-1.02%) ⬇️
src/release-pr.ts 90.03% <0.00%> (-0.67%) ⬇️
src/releasers/php-yoshi.ts 93.02% <0.00%> (-0.39%) ⬇️
src/releasers/java-yoshi.ts 87.76% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f645e87...91020e7. Read the comment docs.

@bcoe bcoe merged commit 6c313c1 into master Aug 18, 2020
@bcoe bcoe deleted the fix-go branch August 18, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants