feat(deps): update dependencies & fix gts lint #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaozhenliu-gg5
commented
Mar 26, 2020
•
xiaozhenliu-gg5
commented
- upgrade Typescript to 3.8.x
- upgrade gts and fix lint.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 88.95% 87.28% -1.68%
==========================================
Files 27 27
Lines 3106 3106
Branches 292 236 -56
==========================================
- Hits 2763 2711 -52
- Misses 342 392 +50
- Partials 1 3 +2
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 26, 2020
| "mocha": "^7.1.1", | ||
| "nock": "^12.0.3", | ||
| "snap-shot-it": "^7.9.3", | ||
| "typescript": "3.8.3" |
There was a problem hiding this comment.
Do you want to add a range specifier?
| "snap-shot-it": "^7.0.0", | ||
| "typescript": "3.6.4" | ||
| "cross-env": "^7.0.2", | ||
| "gts": "^2.0.0-alpha.7", |
There was a problem hiding this comment.
maybe pin to next intead
| }, | ||
| "dependencies": { | ||
| "@octokit/graphql": "^4.3.1", | ||
| "@octokit/request": "^5.3.1", | ||
| "@octokit/rest": "^16.43.1", | ||
| "@types/yargs": "^15.0.4", |
There was a problem hiding this comment.
Huh, why did this sneak into dependencies instead of devDependencies?
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-var-requires |
There was a problem hiding this comment.
If you added the @types package, why not use an import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.