Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to accept --proxy-key and --api-url #180

Merged
merged 8 commits into from
May 31, 2019
Merged

feat: refactor to accept --proxy-key and --api-url #180

merged 8 commits into from
May 31, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 31, 2019

expose configuration dials and knobs for folks who connect to GitHub through a proxy.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2019
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@052c902). Click here to learn what that means.
The diff coverage is 65.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #180   +/-   ##
=========================================
  Coverage          ?   69.85%           
=========================================
  Files             ?       11           
  Lines             ?     1692           
  Branches          ?      147           
=========================================
  Hits              ?     1182           
  Misses            ?      497           
  Partials          ?       13
Impacted Files Coverage Δ
src/github-release.ts 55.35% <50%> (ø)
src/github.ts 53.66% <62.96%> (ø)
src/release-pr.ts 68.53% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052c902...bec5770. Read the comment docs.

@bcoe bcoe merged commit e2c4603 into master May 31, 2019
@bcoe bcoe deleted the new-keys branch May 31, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants