Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest): add support for releasing root module #833

Merged
merged 10 commits into from
Mar 24, 2021
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 20, 2021

Add support for a special "." path which indicates that a root module should be released.

This is for the googleapis use-case.

CC: @joeldodge79

@bcoe bcoe requested a review from a team as a code owner March 20, 2021 00:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2021
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #833 (f866610) into master (f06894c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          64       64           
  Lines        9148     9152    +4     
  Branches      980      930   -50     
=======================================
+ Hits         8575     8579    +4     
  Misses        570      570           
  Partials        3        3           
Impacted Files Coverage Δ
src/manifest.ts 100.00% <100.00%> (ø)
src/release-pr.ts 94.47% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06894c...f866610. Read the comment docs.

Copy link
Collaborator

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised this worked as smoothly as it did! but it does seem like we're missing a changelog entry for @node/pkg1 in the root changelog ?

test/manifest.ts Outdated Show resolved Hide resolved
__snapshots__/manifest.js Outdated Show resolved Hide resolved
@joeldodge79
Copy link
Collaborator

random question: how do you setup interactive debugging on this project? I've been cherry-picking this commit to use vscode debugging

@@ -283,6 +286,77 @@ describe('Manifest', () => {
]);
});

it('allows root module to be published, via special "." path', async function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I think we should add a test under the describe('githubRelease' section. I'd be curious to see what the tag creation looks like for the root package.

also maybe a note somewhere in docs/manifest-releaser.md about this root pkg ability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@bcoe bcoe force-pushed the allow-root-path branch from 0a5df74 to 4744798 Compare March 23, 2021 00:40
Copy link
Collaborator

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor test typo/nits but phew! glad the overwritten changelog was just a test bug

test/manifest.ts Outdated Show resolved Hide resolved
test/manifest.ts Outdated Show resolved Hide resolved
test/manifest.ts Outdated Show resolved Hide resolved
test/manifest.ts Outdated Show resolved Hide resolved
Co-authored-by: Joel Dodge <[email protected]>
@bcoe bcoe requested a review from a team March 24, 2021 15:26
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 24, 2021
bcoe and others added 2 commits March 24, 2021 08:26
Co-authored-by: Joel Dodge <[email protected]>
Co-authored-by: Joel Dodge <[email protected]>
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: Joel Dodge <[email protected]>
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Mar 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 24, 2021
@bcoe bcoe merged commit 7ec1037 into master Mar 24, 2021
@chingor13 chingor13 deleted the allow-root-path branch September 27, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants