Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: generate root when building #2559

Merged
merged 1 commit into from
Mar 23, 2021
Merged

build: generate root when building #2559

merged 1 commit into from
Mar 23, 2021

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 19, 2021

Support generating the top level module (as well as the submodules).

@bcoe bcoe requested a review from sofisl March 19, 2021 23:38
@bcoe bcoe requested a review from a team as a code owner March 19, 2021 23:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021 •
edited
Loading

Codecov Report

Merging #2559 (598dbbe) into master (19bfebf) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
- Coverage   82.88%   82.66%   -0.23%     
==========================================
  Files          11       11              
  Lines        1841     1846       +5     
  Branches      123      103      -20     
==========================================
  Hits         1526     1526              
- Misses        315      320       +5
Impacted Files Coverage Δ
src/generator/generator.ts 48.31% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bfebf...598dbbe. Read the comment docs.

@bcoe bcoe mentioned this pull request Mar 20, 2021
Merged
@sofisl sofisl merged commit 2273a67 into master Mar 23, 2021
@sofisl sofisl deleted the generate-root branch March 23, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @JustinBeckwith @sofisl