Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find first associate pull request #764

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

chingor13
Copy link
Contributor

For some reason, a commit can have multiple associated pull requests. We actually want the first result, not the last and this appears to correctly be the associated pull request that we want.

Fixes #756

@chingor13 chingor13 requested a review from a team as a code owner February 11, 2021 06:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #764 (d8f3a6a) into master (07e2969) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   90.02%   90.22%   +0.19%     
==========================================
  Files          57       57              
  Lines        7490     7467      -23     
  Branches      674      715      +41     
==========================================
- Hits         6743     6737       -6     
+ Misses        746      729      -17     
  Partials        1        1              
Impacted Files Coverage Δ
src/github.ts 83.75% <100.00%> (ø)
src/bin/release-please.ts 88.38% <0.00%> (+6.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e2969...34d0b65. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this works.

@bcoe bcoe merged commit b277b89 into googleapis:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latestTag() does not find stable-branch name without a version in the branch name
2 participants