Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latestTag() does not find stable-branch name without a version in the branch name #756

Closed
chingor13 opened this issue Feb 10, 2021 · 0 comments · Fixed by #758 or #764
Closed

latestTag() does not find stable-branch name without a version in the branch name #756

chingor13 opened this issue Feb 10, 2021 · 0 comments · Fixed by #758 or #764
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

latestTag() assumes that the version can be parsed from the branch name which is not possible when using stable-branch names

We will need to improve/relax the logic for how we find the latest tag.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 10, 2021
@chingor13 chingor13 self-assigned this Feb 10, 2021
@stephaniewang526 stephaniewang526 mentioned this issue Feb 10, 2021
Closed
@chingor13 chingor13 mentioned this issue Feb 10, 2021
Merged
@bcoe bcoe closed this as completed in #758 Feb 11, 2021
@chingor13 chingor13 mentioned this issue Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@chingor13