Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for Data API in Github#getFileContents #551

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

lancedikson
Copy link
Contributor

It brings a unified function for getting file contents with or without Data API.

Fixes #546 🦕

@lancedikson lancedikson requested a review from a team as a code owner September 11, 2020 07:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2020
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #551 into master will increase coverage by 0.16%.
The diff coverage is 98.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage   82.35%   82.51%   +0.16%     
==========================================
  Files          42       42              
  Lines        4856     4907      +51     
  Branches      394      433      +39     
==========================================
+ Hits         3999     4049      +50     
- Misses        856      857       +1     
  Partials        1        1              
Impacted Files Coverage Δ
src/github.ts 81.03% <98.43%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320448b...e623aa9. Read the comment docs.

It brings a unified function for getting file contents with or without Data API.
fixed googleapis#546
@lancedikson lancedikson force-pushed the feature/use-github-data-api branch from 69bbe27 to 91ddc5b Compare September 11, 2020 07:20
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how you've approached this as a progressive enhancement 👍

I'll get this shipped this morning and comment back on the issue, so that you can test things out.

@bcoe bcoe merged commit 40a9c68 into googleapis:master Sep 11, 2020
@lancedikson
Copy link
Contributor Author

Great, thanks, @bcoe, for the feedback and such a quick merge! Appreciate it! 👍 Strange that this issue didn't pop up before as we noticed it just a couple of weeks after we started using release-please. It would be great if you could also publish a new version of release-please-action as we rely on that as a final product :) Thanks again, and have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too large blob to fetch via the Github API
2 participants