Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too large blob to fetch via the Github API #546

Closed
lancedikson opened this issue Sep 10, 2020 · 2 comments · Fixed by #551
Closed

Too large blob to fetch via the Github API #546

lancedikson opened this issue Sep 10, 2020 · 2 comments · Fixed by #551
Assignees
@bcoe
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lancedikson
Copy link
Contributor

Short overview

In a nutshell, release-please can't handle big files (bigger than 1 MB) due to the limitations of Github API. This may cause the bug with release-please not being able to prepare a change-set for a PR.
image

Environment details

  • OS: MacOS and Github Actions (Linux)
  • Node.js version: 12.3.1
  • npm version: 6.13.4
  • release-please version: 6.1.0

Steps to reproduce

  1. Fork the example repo I created for reproducing the error and run release-please locally, or via Github Actions.

Here's an example of a failed Action: https://github.com/lancedikson/release-please-403-example/actions/runs/248586960

Error details

Here's an example of a stack trace we're getting in a private repo, but it's fully reproducible from the example repo:

---------
HttpError: This API returns blobs up to 1 MB in size. The requested blob is too large to fetch via the API, but you can use the Git Data API to request blobs up to 100 MB in size.: {"resource":"Blob","field":"data","code":"too_large"}
    at /home/an/.nvm/versions/node/v12.18.3/lib/node_modules/release-please/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async GitHub.getChangeSet (/home/an/.nvm/versions/node/v12.18.3/lib/node_modules/release-please/build/src/github.js:475:31)
    at async GitHub.openPR (/home/an/.nvm/versions/node/v12.18.3/lib/node_modules/release-please/build/src/github.js:434:25)
    at async Node.openPR (/home/an/.nvm/versions/node/v12.18.3/lib/node_modules/release-please/build/src/release-pr.js:158:20)
    at async Node._run (/home/an/.nvm/versions/node/v12.18.3/lib/node_modules/release-please/build/src/releasers/node.js:83:9)
lancedikson added a commit to lancedikson/release-please that referenced this issue Sep 11, 2020
@lancedikson
feat: adds support for Data API in Github#getFileContents
69bbe27 
It brings a unified function for getting file contents with or without Data API.
fixed googleapis#546
@lancedikson lancedikson mentioned this issue Sep 11, 2020
Merged
lancedikson added a commit to lancedikson/release-please that referenced this issue Sep 11, 2020
@lancedikson
feat: adds support for Data API in Github#getFileContents
91ddc5b 
It brings a unified function for getting file contents with or without Data API.
fixed googleapis#546
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 11, 2020
@bcoe bcoe closed this as completed in #551 Sep 11, 2020
bcoe added a commit that referenced this issue Sep 11, 2020
@lancedikson @bcoe
feat: adds support for Data API in Github#getFileContents (#551)
40a9c68 
It brings a unified function for getting file contents with or without Data API.

Fixes #546

Co-authored-by: Benjamin E. Coe <[email protected]>
@bcoe bcoe reopened this Sep 11, 2020
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 11, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Sep 11, 2020
@bcoe
Copy link
Contributor

bcoe commented Sep 17, 2020

@lancedikson sorry it took me a little while to get a release out the door, [email protected] should have this functionality now. Let me know if it does the trick for you?

@lancedikson
Copy link
Contributor Author

@bcoe, thanks for the release, yes, it works just fine. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcoe bcoe

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds support for Data API in Github#getFileContents lancedikson/release-please
3 participants
@bcoe @lancedikson @yoshi-automation