refactor!: upgrade octokit/gts/typescript #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: octokit has significant interface changes.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 88.95% 80.91% -8.05%
==========================================
Files 27 13 -14
Lines 3106 2305 -801
Branches 292 167 -125
==========================================
- Hits 2763 1865 -898
- Misses 342 439 +97
Partials 1 1
Continue to review full report at Codecov.
|
| "@types/chai": "^4.1.7", | ||
| "@types/mocha": "^7.0.0", | ||
| "@types/node": "^11.13.6", | ||
| "@types/semver": "^7.0.0", | ||
| "c8": "^7.0.0", | ||
| "chai": "^4.2.0", | ||
| "cross-env": "^7.0.0", | ||
| "gts": "^1.0.0", | ||
| "gts": "^2.0.0-alpha.8", |
There was a problem hiding this comment.
I saw some of package use next tag here. Dose it matter here?
There was a problem hiding this comment.
I prefer being explicit with the dependency, as soon as we do a few GAPIC library updates, I think we can go ahead and migrate gts to 2.x 😄
src/conventional-commits.ts
Outdated
| @@ -11,14 +11,15 @@ | |||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
| /* eslint-disable @typescript-eslint/no-var-requires */ | |||
There was a problem hiding this comment.
eslint-disable affect entire file, is this what we want?
summer-ji-eng
approved these changes
Mar 27, 2020
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [4.0.0](https://github.com/googleapis/release-please/compare/v3.3.0...v4.0.0) (2020-03-27) ### ⚠ BREAKING CHANGES * upgrade octokit/gts/typescript (#381) ### Code Refactoring * upgrade octokit/gts/typescript ([#381](https://github.com/googleapis/release-please/issues/381)) ([4e0bf11](https://github.com/googleapis/release-please/commit/4e0bf11b7f4217b5c6b8cd1aa9ea4db1bce06b89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this pull request
Apr 8, 2020
4e0bf11 commit 4e0bf11 Author: Benjamin E. Coe <[email protected]> Date: Fri Mar 27 12:19:26 2020 -0700 refactor!: upgrade octokit/gts/typescript (#381)
yoshi-automation
added a commit
that referenced
this pull request
Apr 10, 2020
Source-Repo: googleapis/release-please Source-Sha: 4e0bf11 Source-Link: 4e0bf11 Author: Benjamin E. Coe <[email protected]> Date: Fri Mar 27 12:19:26 2020 -0700 Original-Commit-Message: refactor!: upgrade octokit/gts/typescript (#381)
yoshi-automation
added a commit
that referenced
this pull request
Apr 11, 2020
Source-Repo: googleapis/release-please Source-Sha: 4e0bf11 Source-Link: 4e0bf11 Author: Benjamin E. Coe <[email protected]> Date: Fri Mar 27 12:19:26 2020 -0700 Original-Commit-Message: refactor!: upgrade octokit/gts/typescript (#381)
yoshi-automation
added a commit
that referenced
this pull request
Apr 12, 2020
Source-Repo: googleapis/release-please Source-Sha: 4e0bf11 Source-Link: 4e0bf11 Author: Benjamin E. Coe <[email protected]> Date: Fri Mar 27 12:19:26 2020 -0700 Original-Commit-Message: refactor!: upgrade octokit/gts/typescript (#381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xiaozhenliu-gg5 I ended up pulling over your work from #380 into this PR, as I had to do a significant amount of refactoring of types to upgrade @octokit (I'd been putting off this update for weeks because I knew it would take so much playing around).
Sorry to have wasted a little bit of your time on #380.