Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use built-in release-please types #900

Merged
merged 1 commit into from
Dec 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

import * as core from '@actions/core';
import {GitHub, Manifest} from 'release-please';
import {GitHub, Manifest, CreatedRelease, PullRequest} from 'release-please';

const DEFAULT_CONFIG_FILE = 'release-please-config.json';
const DEFAULT_MANIFEST_FILE = '.release-please-manifest.json';
Expand Down Expand Up @@ -42,34 +42,6 @@ interface ActionInputs {
includeComponentInTag?: boolean;
}

// TODO: replace this interface is exported from release-please
interface PullRequest {
readonly headBranchName: string;
readonly baseBranchName: string;
readonly number: number;
readonly title: string;
readonly body: string;
readonly labels: string[];
readonly files: string[];
readonly sha?: string;
}
// TODO: replace this interface is exported from release-please
interface CreatedRelease {
id: number;
path: string;
version: string;
major: number;
minor: number;
patch: number;
name?: string;
tagName: string;
sha: string;
notes?: string;
url: string;
draft?: boolean;
uploadUrl?: string;
}

function parseInputs(): ActionInputs {
const inputs: ActionInputs = {
token: core.getInput('token', {required: true}),
Expand Down