Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: bump release-please from 15.13.0 to 16.1.0" #847

Merged

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Nov 1, 2023

Reverts google-github-actions/release-please-action#845

The action can't build the single js file via ncc with the newest version of release-please

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
Error: Module parse failed: Unexpected token (26:23)
File was processed with these loaders:
 * ./node_modules/@vercel/ncc/dist/ncc/loaders/empty-loader.js
 * ./node_modules/@vercel/ncc/dist/ncc/loaders/relocate-loader.js
 * ./node_modules/@vercel/ncc/dist/ncc/loaders/shebang-loader.js
You may need an additional loader to handle the result of these loaders.
|     npm_lifecycle_event: event,
|     npm_lifecycle_script: cmd,
>     __webpack_require__.ab + "node-gyp.js",
|   })
| 
    at /home/chingor/code/release-please-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:38:1896272
    at /home/chingor/code/release-please-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:38:396262
    at _done (eval at create (/home/chingor/code/release-please-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:21:75523), <anonymous>:9:1)
    at eval (eval at create (/home/chingor/code/release-please-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:21:75523), <anonymous>:34:22)

@chingor13 chingor13 enabled auto-merge (squash) November 1, 2023 23:26
@chingor13 chingor13 requested a review from bcoe November 1, 2023 23:27
@chingor13 chingor13 merged commit c18751a into main Nov 2, 2023
@chingor13 chingor13 deleted the revert-845-dependabot/npm_and_yarn/release-please-16.1.0 branch November 2, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants