Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat: incorporate upstream changes #73

Merged
merged 4 commits into from
Jul 31, 2020
Merged

feat: incorporate upstream changes #73

merged 4 commits into from
Jul 31, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 31, 2020 •
edited
Loading

  • feat: Support MULAW audio encoding
  • feat: Support MP3_64_KBPS audio encoding
  • feat: Support timepointing via SSML tag
  • feat: Support quota_project_id
  • docs: generate and upload docfx yaml files
  • testing: add docs-presubmit build

Upstream change:
googleapis/googleapis@a94df49

@tmatsuo tmatsuo requested review from sirtorry, telpirion and a team as code owners July 31, 2020 01:29
@tmatsuo tmatsuo requested review from kurtisvg and removed request for a team July 31, 2020 01:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@tmatsuo tmatsuo mentioned this pull request Jul 31, 2020
Merged
busunkim96
busunkim96 reviewed Jul 31, 2020
View reviewed changes
google/cloud/texttospeech_v1/services/text_to_speech/client.py Outdated
Comment on lines 231 to 243
get supported "en-\*" voices; when specifying "no", you
will get supported "no-\*" (Norwegian) and "nb-*"
get supported "en-*" voices; when specifying "no", you
will get supported "no-*" (Norwegian) and "nb-*"
(Norwegian Bokmal) voices; specifying "zh" will also get
supported "cmn-*" voices; specifying "zh-hk" will also
get supported "yue-\*" voices.
get supported "yue-*" voices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the synth replace isn't working for this, but this is the reason for the docs failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the autosynth PR also has the same thing:

https://github.com/googleapis/python-texttospeech/pull/70/files#diff-b794d7ad2724dfc5c6821d8d0edb1bebR239

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured it out:

-    "((en)|(no)|(nb)(cmn)|(yue))-\*",
+    "((en)|(no)|(nb)|(cmn)|(yue))-\*",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's green!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Thank you! 😁

@tmatsuo tmatsuo mentioned this pull request Jul 31, 2020
Merged
@tmatsuo tmatsuo force-pushed the manual-synth branch 2 times, most recently from 8e83840 to d7258d8 Compare July 31, 2020 03:32
@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 31, 2020
@tmatsuo tmatsuo removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 31, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 31, 2020

We can merge this, but isn't it better to have autosynth do the job? It'll have a better changelig I think.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 31, 2020

I'm open to merge this, but in that case, let's have a better commit logs and PR description.

@tmatsuo tmatsuo changed the title testing: manually running synthtool feat: incorporate upstream changes Jul 31, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 31, 2020

@busunkim96 I updated the PR title and description. How does it look?

busunkim96
busunkim96 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmatsuo, could you bump these two dependencies in setup.py? They are needed for some of the new changes in this PR.

'google-api-core[grpc] >= 1.22.0, < 2.0.0dev',

'proto-plus >= 1.4.0',

Takashi Matsuo added 4 commits July 31, 2020 17:03
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 31, 2020

I added feat: Support quota_project_id in the description. I think we should put those bullets into the commit log when we squash and merge.

@tmatsuo tmatsuo merged commit 8ee5447 into googleapis:master Jul 31, 2020
@tmatsuo tmatsuo deleted the manual-synth branch July 31, 2020 17:13
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 11, 2020
@release-please
chore: release 2.2.0 (#75)
a282e62 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://github.com/googleapis/python-texttospeech/compare/v2.1.0...v2.2.0) (2020-08-10)


### Features

* incorporate upstream changes ([#73](https://github.com/googleapis/python-texttospeech/issues/73)) ([8ee5447](https://github.com/googleapis/python-texttospeech/commit/8ee544740f18497d9925bcf77e5ab96695503589))

---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@sirtorry sirtorry Awaiting requested review from sirtorry

@telpirion telpirion Awaiting requested review from telpirion

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmatsuo @busunkim96