docs(samples): add samples for CMMR phase 2 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
api: spanner
rahul2393
changed the title
vi3k6i5
added
the
do not merge
olavloite
reviewed
Feb 2, 2022
samples/samples/snippets.py
Outdated
| base_config = spanner_client.instance_admin_api.get_instance_config( | ||
| name="{}/instanceConfigs/{}".format(spanner_client.project_name, base_instance_config)) | ||
| replicas = [] | ||
| for replica in base_config.replicas: |
There was a problem hiding this comment.
nit: Add a comment that it is required that the custom configuration contains all the replicas of the base config + at least one optional replica. That makes it clearer to the user why we are doing this.
samples/samples/snippets_test.py
Outdated
| def test_update_instance_config(capsys, user_managed_instance_config_id): | ||
| snippets.update_instance_config(user_managed_instance_config_id) | ||
| out, _ = capsys.readouterr() | ||
| assert "custom-updated-sample-config" in out |
There was a problem hiding this comment.
nit: Add something like 'Updated ...' to the assert here, so it's easier to see that this really verifies that the function succeeded.
samples/samples/snippets_test.py
Outdated
| def test_create_instance_config(capsys, user_managed_instance_config_id): | ||
| snippets.create_instance_config("base-config", user_managed_instance_config_id) | ||
| out, _ = capsys.readouterr() | ||
| assert "custom-sample-config" in out |
There was a problem hiding this comment.
nit: Add something like 'Created ...' to the assert here, so it's easier to see that this really verifies that the function succeeded.
rahul2393
force-pushed
the
spanner-custom-replication-topology
branch
from
a03c43b to
7f7af44
Compare
rahul2393
changed the title
rahul2393
force-pushed
the
spanner-custom-replication-topology
branch
from
c0d1b48 to
b116734
Compare
rahul2393
force-pushed
the
spanner-custom-replication-topology
branch
from
b116734 to
6f4f268
Compare
asthamohta
removed
the
do not merge
olavloite
approved these changes
Sep 28, 2022
ansh0l
approved these changes
Sep 29, 2022
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and samples for user-managed instance configurations
BEGIN_COMMIT_OVERRIDE
docs(samples): add samples for CMMR phase 2
END_COMMIT_OVERRIDE