Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send client id with StreamingPullRequest #62

Closed
pradn opened this issue Mar 26, 2020 · 0 comments · Fixed by #58
Closed

Send client id with StreamingPullRequest #62

pradn opened this issue Mar 26, 2020 · 0 comments · Fixed by #58
Assignees
@pradn
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@pradn
Copy link
Contributor

pradn commented Mar 26, 2020

  • The client id should be created randomly for each StreamingPullManager and will be used to establish affinity across stream disconnections/retries.
  • Server-client affinity is important for ordering keys, where the backend tries to send the same keys to the same client.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 26, 2020
@pradn pradn mentioned this issue Mar 26, 2020
Merged
@pradn pradn self-assigned this Mar 26, 2020
@meredithslota meredithslota added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 26, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 22, 2020
@pradn
feat: send client id with StreamingPullRequest (#58)
9f8acfa 
- The client id is created randomly for each StreamingPullManager and is used to establish affinity across stream disconnections/retries.
- Server-client affinity is important for ordering keys, where the backend tries to send the same keys to the same client.

Fixes #62
@release-please release-please bot mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pradn pradn

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: send client id with StreamingPullRequest pradn/python-pubsub
2 participants
@pradn @meredithslota