link issue to move emulator code

googleapis · Jan 24, 2025 · 7099d5e · 7099d5e
1 parent 0f09432
commit 7099d5e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/google/cloud/pubsub_v1/subscriber/client.py b/google/cloud/pubsub_v1/subscriber/client.py
@@ -81,6 +81,8 @@ def __init__(
         # Sanity check: Is our goal to use the emulator?
         # If so, create a grpc insecure channel with the emulator host
         # as the target.
+        # TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
+        # code below to test files.
         if os.environ.get("PUBSUB_EMULATOR_HOST"):
             kwargs["client_options"] = {
                 "api_endpoint": os.environ.get("PUBSUB_EMULATOR_HOST")

diff --git a/google/pubsub_v1/services/publisher/client.py b/google/pubsub_v1/services/publisher/client.py
@@ -712,7 +712,9 @@ def __init__(
                 else cast(Callable[..., PublisherTransport], transport)
             )
             # initialize with the provided callable or the passed in class
-
+
+            # TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
+            # code below to test files.
             emulator_host = os.environ.get("PUBSUB_EMULATOR_HOST")
             if emulator_host:
                 if issubclass(transport_init, type(self)._transport_registry["grpc"]):

diff --git a/google/pubsub_v1/services/schema_service/client.py b/google/pubsub_v1/services/schema_service/client.py
@@ -665,6 +665,8 @@ def __init__(
             )
             # initialize with the provided callable or the passed in class
 
+            # TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
+            # code below to test files.
             emulator_host = os.environ.get("PUBSUB_EMULATOR_HOST")
             if emulator_host:
                 if issubclass(transport_init, type(self)._transport_registry["grpc"]):

diff --git a/google/pubsub_v1/services/subscriber/client.py b/google/pubsub_v1/services/subscriber/client.py
@@ -717,6 +717,8 @@ def __init__(
             )
             # initialize with the provided callable or the passed in class
 
+            # TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
+            # code below to test files.
             emulator_host = os.environ.get("PUBSUB_EMULATOR_HOST")
             if emulator_host:
                 if issubclass(transport_init, type(self)._transport_registry["grpc"]):