fix: resolve issue importing library #64
Conversation
product-auto-label
bot
added
the
api: gkehub
google-cla
bot
added
the
cla: yes
|
|
There was a problem hiding this comment.
configmanagement and multiclusteringress live under the google/cloud/gkehub/v1 in the protos so this new namespacing seems correct. Leaving the types here also SGTM, since the protos are clearly nested under a specific version of gkehub.
However, I believe we agreed on generating library types through proto-plus (like python-access-approval). In the event either of these sub packages turns into its own GAPIC (which does look pretty unlikely in this case) the change will be non-breaking. IMO the library types being consistently proto-plus also provides a better end user experience.
For more discussion on a similar issue, see https://github.com/googleapis/python-access-context-manager/issues/42.
parthea
force-pushed
the
fix-dependency-import
branch
from
4b29b3d to
9f3cd73
Compare
|
@busunkim96 Please could you review/approve? |
parthea
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
🤖 I have created a release \*beep\* \*boop\* --- ### [0.2.1](https://github.com/googleapis/python-gke-hub/compare/v0.2.0...v0.2.1) (2021-08-20) ### Bug Fixes * resolve issue importing library ([#64](https://github.com/googleapis/python-gke-hub/issues/64)) ([cfa166e](https://github.com/googleapis/python-gke-hub/commit/cfa166e9b9024920bd00b5994d2638ab7716c2d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #63 🦕