Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support limit to last feature #57

Merged
merged 12 commits into from
Jun 26, 2020
Merged

feat: support limit to last feature #57

merged 12 commits into from
Jun 26, 2020

Conversation

IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Jun 4, 2020 •
edited
Loading

Pushing an implementation with de-deprecation of the get() method (as @BenWhitehead mentioned).

@IlyaFaer IlyaFaer added api: firestore Issues related to the googleapis/python-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 4, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2020
IlyaFaer
IlyaFaer commented Jun 4, 2020
View reviewed changes
@IlyaFaer
Copy link
Author

IlyaFaer commented Jun 4, 2020 •
edited
Loading

Should we add a system test for this feature?

@IlyaFaer IlyaFaer marked this pull request as ready for review June 4, 2020 14:01
@IlyaFaer IlyaFaer requested review from BenWhitehead and crwilcox June 4, 2020 14:09
@BenWhitehead
Copy link
Collaborator

@crwilcox I'll defer to you on the python code change.

BenWhitehead
BenWhitehead reviewed Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the feature, deferring to python expertise for the code change.

crwilcox
crwilcox suggested changes Jun 11, 2020
View reviewed changes
crwilcox
crwilcox reviewed Jun 15, 2020
View reviewed changes
BenWhitehead
BenWhitehead reviewed Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comment/docs requests, but leaving it up to @crwilcox for approval and merge.

@crwilcox
Copy link
Contributor

@IlyaFaer @BenWhitehead I think we may want this in before releasing 1.8.0

@BenWhitehead
Copy link
Collaborator

Yeah, we definitely want this pre v2

@crwilcox
Copy link
Contributor

Thanks for the updated comments. Merging.

@crwilcox crwilcox merged commit 8c75e21 into googleapis:master Jun 26, 2020
rafilong added a commit to rafilong/python-firestore that referenced this pull request Aug 6, 2020
@rafilong
feat: integrate limit_to_last changes from googleapis#57 to async
fb09448
@rafilong rafilong mentioned this pull request Aug 6, 2020
Merged
rafilong added a commit that referenced this pull request Aug 7, 2020
@rafilong
feat: integrate limit to last (#145)
55da695 
* feat: integrate limit_to_last changes from #57 to async

* fix: whitespace in docs

* fix: whitespace in docs
@IlyaFaer IlyaFaer deleted the limit_to_last branch November 30, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead left review comments

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IlyaFaer @BenWhitehead @crwilcox @googlebot