Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Document.set docstring mentions option argument, does not describe merge #277

Closed
tseaver opened this issue Dec 15, 2020 · 0 comments · Fixed by #278
Closed

Docs: Document.set docstring mentions option argument, does not describe merge #277

tseaver opened this issue Dec 15, 2020 · 0 comments · Fixed by #278
Assignees
@tseaver
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: docs Improvement to the documentation for an API.

Comments

@tseaver
Copy link
Contributor

tseaver commented Dec 15, 2020

See the API docs.
@tseaver tseaver self-assigned this Dec 15, 2020
@tseaver tseaver transferred this issue from googleapis/python-datastore Dec 15, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 15, 2020
@tseaver tseaver mentioned this issue Dec 15, 2020
Closed
tseaver added a commit that referenced this issue Dec 15, 2020
@tseaver
docs: clarify semantics of 'merge' argument to 'Document.set'
e3c4ac6 
Closes #277
@tseaver tseaver mentioned this issue Dec 15, 2020
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Dec 16, 2020
@tseaver tseaver added type: docs Improvement to the documentation for an API. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Dec 29, 2020
tseaver added a commit that referenced this issue Feb 2, 2021
@tseaver @craiglabenz
docs: clarify semantics of 'merge' argument to 'Document.set' (#278)
29c6374 
Restore undocumented classes after async split.

Closes #277

Co-authored-by: Craig Labenz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the googleapis/python-firestore API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: clarify semantics of 'merge' argument to 'Document.set' googleapis/python-firestore
2 participants
@tseaver @yoshi-automation