Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add ModuleNotFoundError handler for pandas_backports #319

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Jan 28, 2025

Restores the ModuleNotFoundError handler in pandas_backports.py and adds unit tests. This handler is required by python-bigquery-pandas tests (see link). The handler was previously removed due to insufficient test coverage after dropping Python 3.7 support (#313).

@chelsea-lin chelsea-lin requested a review from Linchin January 28, 2025 21:08
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Jan 28, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_unittest branch from b9c191f to 839df00 Compare January 30, 2025 18:27
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 30, 2025
@chelsea-lin chelsea-lin changed the title fix: bring back ModuleNotFoundError handler in pandas_backports.py fix: Re-add ModuleNotFoundError handler for pandas_backports Jan 30, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review January 30, 2025 21:16
@chelsea-lin chelsea-lin requested review from a team as code owners January 30, 2025 21:16
@Linchin Linchin merged commit 931ff8a into main Jan 30, 2025
22 checks passed
@Linchin Linchin deleted the main_chelsealin_unittest branch January 30, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants