Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Arrow types for efficient JSON data representation in pyarrow #312

Merged
merged 4 commits into from
Jan 17, 2025
Merged

feat: Add Arrow types for efficient JSON data representation in pyarrow #312

merged 4 commits into from
Jan 17, 2025

Conversation

chelsea-lin
Copy link
Contributor

This change is adding ArrowJSONtype to extend pyarrow type for the JSONDtype extension type.

  • Fixes internal bug b/312728178 (design doc: go/bf-json)
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal bug b/312728178 🦕

@chelsea-lin chelsea-lin requested a review from tswast January 9, 2025 17:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Jan 9, 2025
@chelsea-lin chelsea-lin changed the title feat: add ArrowJSONtype to extend pyarrow for JSONDtype feat: Add Arrow types for efficient JSON data representation in pyarrow Jan 16, 2025
tswast
tswast approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_arrowjsontype branch from 4475f9c to fdad61e Compare January 17, 2025 22:30
@chelsea-lin chelsea-lin marked this pull request as ready for review January 17, 2025 22:30
@chelsea-lin chelsea-lin requested review from a team as code owners January 17, 2025 22:30
@chelsea-lin chelsea-lin requested a review from Neenu1995 January 17, 2025 22:30
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_arrowjsontype branch from b287870 to 14a6dcd Compare January 17, 2025 23:26
@chelsea-lin chelsea-lin merged commit d9992fc into main Jan 17, 2025
23 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_arrowjsontype branch January 17, 2025 23:29
@release-please release-please bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995 Neenu1995 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@GaoleMeng GaoleMeng

Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chelsea-lin @tswast @GaoleMeng