-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update mininum support to Python 3.9, Pandas 1.5.0, Numpy 1.20.3 #286
base: main
Are you sure you want to change the base?
Conversation
Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update https://github.com/googleapis/python-db-dtypes-pandas/blob/main/.github/workflows/unittest.yml to drop 3.7 too.
Might need to exclude that file in https://github.com/googleapis/python-db-dtypes-pandas/blob/main/owlbot.py until we drop Python 3.7 google-wide.
@chalmerlowe has been working on an effort to drop support for python 3.7 and 3.8 (see internal doc go/drop-python-37). We likely will need to drop the support in sync with that. |
3ccb77c
to
0b3753d
Compare
761e56c
to
22526c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are removing this, please update constraints-3.9.txt to include all the minimum versions from setup.py
0564266
to
6e7adaa
Compare
6e7adaa
to
80f78b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please also remove all references to Python 3.8
, since we have approval to deprecate support for that version as well as 3.7.
I did a comprehensive review of all the files in the repo to find any references to 3.
since there may be conditionals such as:
< 3.9
or <= 3.9
and because there may be references to things that are no longer needed if support for a specific version of Python is dropped.
The following files have content that needs to be corrected OR reviewed for correctness AND/OR deleted.
* CONTRIBUTING.rst (multiple references, including instructions that guide users to use 3.8)
* noxfile.py (references 3.8)
* samples/snippets/noxfile.py (references 3.8)
* owlbot.py
* pytest.ini (references removing code once we drop support for 3.7 and 3.8)
* python-db-dtypes-pandas/README.rst (references supported versions of Python)
* docs/README.rst (references supported versions of Python) (probably autogenerated by sphinx
so maybe no action needed)
* setup.py (references 3.8)
* sync-repo-settings.yaml (CI/CD checks related to 3.8)
* lint.yml (references 3.8)
* unittest.yml (references 3.8)
* test-samples-impl.sh (references using an older version of virtualenv to maintain 3.7 compatibility)
#NOTE I think I have a version of virtualenv that will work. I will try to get that version
(if memory serves, the latest version does not work so we need a slightly older one).
* .kokoro/samples/python3.7/common.cfg (whole directory for 3.7)
* .kokoro/samples/python3.8/common.cfg (whole directory for 3.8)
* db_dtypes/__init__.py
* references need for an older version of pandas if using 3.7 and does a conditional check
for that version of pandas
* includes a warning indicating that Python 3.7 and 3.8 are deprecated and does a check
for Python version
* samples/snippets/requirements-test.txt (references 3.7/>3.7)
* install_deps.tmpl.rst (references 3.7+)
* constraints-3.8.txt (delete)
If you have questions about a specific change, please reach out.
#284 introduce the
ArrowExtensionArray
dependency, which requires pandas version 1.5.0 and above. The pandas 1.5.0+ is only compatible with Python 3.8+ and NumPy 1.20.3+.Fixes internal bug b/312728178 🦕