-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add test proxy #836
Merged
Merged
feat: add test proxy #836
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
aa1e40e
support emulator in data client
daniel-sanche b059139
added test proxy files
daniel-sanche 3ed2168
cleaned up noxfile
daniel-sanche 5199839
moved protos to subdir
daniel-sanche 4e14bf3
close client
daniel-sanche cbb95c9
moved handlers into subdir
daniel-sanche f43aac1
reverted close
daniel-sanche 91fc1e6
removed user agent
daniel-sanche 06e5276
removed go submodule
daniel-sanche 62b8e48
fixied typo
daniel-sanche 237e051
removed unneeded files
daniel-sanche 868ff2e
removed duplicate client handler legacy
daniel-sanche 21a5077
Merge branch 'v3' into test_proxy2
daniel-sanche 02f0c09
addressed PR comments
daniel-sanche 456caba
ran blacken
daniel-sanche f3627c1
Merge branch 'v3' into test_proxy2
daniel-sanche bcc02d7
fix method name
daniel-sanche 5e7c156
added missing import
daniel-sanche 604d3d8
added conformance tests to kokoro
daniel-sanche 14f359d
added conformance to nox sessions
daniel-sanche 858c57d
Revert unwwanted noxfile changes
daniel-sanche 36a3153
added missing run_tests file
daniel-sanche 07b39b1
changed conformance test kokoro configs
daniel-sanche 5d90478
ran blacken
daniel-sanche b69da5a
install golang for conformance tests
daniel-sanche df3ea47
update before attempting install
daniel-sanche 8dcd444
changed go install method
daniel-sanche 94a8684
moved go installation to run_tests
daniel-sanche 72b8d1b
fixed failing conformance tests
daniel-sanche 8496211
Merge branch 'v3' into test_proxy2
daniel-sanche 71ba0ea
fixed read rows test error
daniel-sanche 94e98db
fixed conformance test errors
daniel-sanche 320d157
download go locally instead of installing to system
daniel-sanche 5064870
fixed lint issue
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
removed duplicate client handler legacy
- Loading branch information
commit 868ff2eafe0a6fb57a242f1106a70543a77f9a1f
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much do you want to support legacy client? I only see 3 APIs are implemented, what's the future plan (including deprecation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will support them side-by-side for the medium term, with plans to eventually deprecate the old client. For now, my attention has been focused on the new data client. But it would be good to get test parity at some point