feat: Add support for array and float32 SQL query params #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
jackdingilian
force-pushed
the
array-param-support
branch
2 times, most recently
from
2dee92c to
ddaa591
Compare
jackdingilian
force-pushed
the
array-param-support
branch
2 times, most recently
from
e7a9889 to
23689d2
Compare
jackdingilian
force-pushed
the
array-param-support
branch
from
23689d2 to
c7169ba
Compare
daniel-sanche
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
|
Actually, it looks like Owlbot can't run on this PR since it's based on a fork. I remember seeing something about that being a new security policy. Could you re-submit this as an internal branch? (Let me know if you're missing permissions) |
|
Moved to #1078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One note: we currently support inferring the type of simple query params. Here I opt not to attempt this for lists. We could infer the type from the first element of the list (and error if it is None, or infer from the first non-null element). For now I think this approach is less error prone, and we can ease this restriction in the future
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕