-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass retry from Job.result() to Job.done() #41
feat: pass retry from Job.result() to Job.done() #41
Conversation
This PR is strictly connected to googleapis/python-api-core#9, and should not be merged before №9 |
This will need to be updated to set the minimum api-core version in setup.py to 1.23.0 after googleapis/python-api-core#96 is released. |
1.23.0 has been released. Work can continue on this PR |
Only one error is appearing:
Doesn't seem to be related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing update to minimum versions.
Filed #339 to look into the test failure. I've assigned to myself, as it might be related to some refactoring I recently completed. |
I think, a lot of tests will fail. And in many tests we'll have to add one more arg. That's why I've added the |
Okay, that makes sense. So long as we have some tests that have a custom retry, I'm okay with only populating it when it's something other than the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing any tests that verify the retry behavior is working as expected.
I'd like to see the test update I suggested here: https://github.com/googleapis/python-bigquery/pull/340/files#r511017196
The QueryJob
class overrides result()
, so we'll need a test that does the same but for QueryJob specifically.
…into retry_from_result_to_done
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
@tswast, sorry, I'm little bit besieged by tasks, not able to continue with this right now. @HemangChothani kindly agreed to take a look at this PR. |
Closes #24