-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BigQuery storage client support to DB API #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General structure LGTM. Replacing self._query_data
with an iterable that calls the BQ Storage API under the covers is exactly what I imagined.
Once the PR is ready, let's have @shollyman or someone he delegates to do the final review.
The coverage failure is due to Python 2.7 unit tests are not run on Kokoro:
The tests pass just fine locally, and the total coverage is 100%. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@tseaver As a co-author of one of the changes, please just appease the CLA bot, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. We'll want to update this from v1beta1->v1 in the near future, not sure how you'd like to track that.
@shollyman Track in the sense of the tasks that need to be done for the promotion to GA? A GitHub issue for it would be just fine. |
@tseaver Friendly ping, the CLA bot still needs confirmation from you. Thanks! |
@googlebot I signed it! |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Can usage for this be updated at https://github.com/mxmzdlv/pybigquery/blob/master/README.rst#usage ? |
To be closed as per googleapis/python-bigquery-sqlalchemy#61 (comment) ? |
@yiga2 Sorry, I'm not following? What should be closed, this PR has been merged? |
My bad - meant to close googleapis/python-bigquery-sqlalchemy#41 |
Closes #16.
The title says it all. Details in the ticket description.
PR checklist: