fix: no longer set autodetect=True with empty schema in load_table_from_json() #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
tswast
reviewed
Jan 26, 2024
| @@ -2833,9 +2833,6 @@ def load_table_from_json( | |||
|
|
|||
| new_job_config.source_format = job.SourceFormat.NEWLINE_DELIMITED_JSON | |||
|
|
|||
| if new_job_config.schema is None: | |||
There was a problem hiding this comment.
We are still getting test failures with this change:
> raise exceptions.from_http_response(exc.response)
E google.api_core.exceptions.BadRequest: 400 POST https://bigquery.googleapis.com/upload/bigquery/v2/projects/precise-truck-742/jobs?uploadType=multipart: No schema specified on job or table.
I think we can only omit these if the table already exists and we are appending rows.
There was a problem hiding this comment.
Thanks, I think I made a mistake in my test code and created the table with schema in it.
4 tasks
|
use #1804 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, if we don't set
autodetect=Truewhen schema is empty, the backend will throw an error. This has changed now, backend will autodetect even if we don't send autodetect value. This has caused some issues with users, when the detected schema doesn't match that of the existing table. (#1228, #1563)For more discussions, see #1228.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1228 🦕