Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update region tag and move sample and test #1648

Merged
merged 10 commits into from
Sep 15, 2023
Merged

chore(docs): update region tag and move sample and test #1648

merged 10 commits into from
Sep 15, 2023

Conversation

meredithslota
Copy link
Contributor

Partially addresses #773 🦕

@meredithslota meredithslota requested review from a team as code owners August 18, 2023 18:24
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 18, 2023
@snippet-bot
Copy link

snippet-bot bot commented Aug 18, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.
You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Aug 18, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 18, 2023
@meredithslota meredithslota requested review from chalmerlowe and removed request for dandhlee and obada-ab August 28, 2023 17:06
chalmerlowe
chalmerlowe approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meredithslota meredithslota merged commit 7248f1f into main Sep 15, 2023
@meredithslota meredithslota deleted the sample-migration-773 branch September 15, 2023 14:57
@meredithslota
Copy link
Contributor Author

Sent cl/565816568 to update the sample locations.

@meredithslota meredithslota mentioned this pull request Sep 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meredithslota @chalmerlowe