-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute_sql function to enable execution of SQL code where no DataFrame is returned #90
Conversation
…aFrame is returned
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
===========================================
- Coverage 73.44% 27.98% -45.47%
===========================================
Files 4 4
Lines 1578 1583 +5
===========================================
- Hits 1159 443 -716
- Misses 419 1140 +721
Continue to review full report at Codecov.
|
private_key=private_key, | ||
auth_local_webserver=auth_local_webserver, | ||
dialect=dialect, **kwargs) | ||
except KeyError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's mostly coincidental that the existing function raises a KeyError
. Can we find a more coherent way of doing this?
Could you rebase this PR on the latest version in master? There have been some significant changes since this was opened. We changed what library we use to actually make the API calls to BigQuery. |
@tswast Thanks so much for the update. I'll change this PR based on the latest code in master. |
@madhav-datt Would love to merge this. Let us know if you're up for updating this. |
I've been thinking about this in regards to |
Thanks for the follow up! Sure - I'll go ahead and update the pull request. |
@madhav-datt this is v close! How would you feel about pushing over the line? |
Thank you for the contribution @madhav-datt and your patience. I'm closing this in favor of #286 which adds a |
Initial pull request based on the discussion and issue explained here. I'd love to discuss any changes to the design of this function, or if it might be better to add this functionality elsewhere.