Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: xfail test replace schema due change in BQ backend #77

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 3, 2017

This PR is to xfail the intermittently failing test test_upload_data_if_table_exists_replace. This test started failing around July 11th or so. I've created a new issue in the BigQuery issue tracker here: https://issuetracker.google.com/issues/64329577.

I plan to keep #75 until we receive a response from the BigQuery team in the issue tracker.

@parthea parthea force-pushed the xfail-test-replace-schema branch from 1bf0d8d to 66b2b0a Compare August 3, 2017 10:55
@codecov-io
Copy link

codecov-io commented Aug 3, 2017

Codecov Report

Merging #77 into master will decrease coverage by 45.4%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #77       +/-   ##
===========================================
- Coverage   73.57%   28.17%   -45.41%     
===========================================
  Files           4        4               
  Lines        1544     1544               
===========================================
- Hits         1136      435      -701     
- Misses        408     1109      +701
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 27.94% <100%> (-54.94%) ⬇️
pandas_gbq/gbq.py 19.2% <0%> (-56.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b25a6b...66b2b0a. Read the comment docs.

@parthea
Copy link
Contributor Author

parthea commented Aug 3, 2017

All tests passed on my branch. https://travis-ci.org/parthea/pandas-gbq/builds/260556797

I'm going to go ahead and merge this just so we can get master passing. Please feel free to add comments after I merge. I'll follow up with another PR if we need to make changes.

@parthea parthea merged commit 012057d into googleapis:master Aug 3, 2017
@parthea parthea deleted the xfail-test-replace-schema branch August 3, 2017 15:42
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

At some point soon I'd like to get to_gqq using a load job, instead, which should be more reliable. #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants