Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Catch RefreshError in _try_credentials() #227

Merged
merged 2 commits into from
Oct 12, 2018
Merged

ENH: Catch RefreshError in _try_credentials() #227

merged 2 commits into from
Oct 12, 2018

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 12, 2018

Fixes the build errors on Travis, where GCE credentials are available but not actually useful.

Closes #226.

@tswast
Copy link
Collaborator Author

tswast commented Oct 12, 2018

Successful build: https://travis-ci.org/tswast/pandas-gbq/builds/440741599

@tswast tswast requested a review from max-sixty October 12, 2018 17:44
max-sixty
max-sixty approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tswast !
Feel free to add to changelog

@tswast tswast merged commit 0dd2d5e into googleapis:master Oct 12, 2018
@tswast tswast deleted the issue226-refresherror branch October 12, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @max-sixty