Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update dataframe.to_gbq to dedup column names. #286

Merged
merged 11 commits into from
Dec 28, 2023
Merged

Fix: Update dataframe.to_gbq to dedup column names. #286

merged 11 commits into from
Dec 28, 2023

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Dec 21, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 21, 2023
Genesis929 and others added 7 commits December 26, 2023 19:05
@Genesis929
remove escaping.
085618a
@Genesis929
remove unused import
9aea94c
@shobsi @Genesis929
fix: make Series.str.replace work for simple strings (#285)
65de270
@TrevorBergeron @tswast @Genesis929
feat: specific pyarrow mappings for decimal, bytes types (#283)
0b262c3 
* feat: new bytes, json, decimal type mappings

* amend tests to reflect new types

* add implicit type conversion for df.replace

* more type casting tests

* skip pandas 1.x for more tests

---------

Co-authored-by: Tim Swast <[email protected]>
@shobsi @Genesis929
docs: code samples for drop and fillna (#284)
8ea4a66
@shobsi @Genesis929
docs: code samples for reset_index and sort_values (#282)
a3ff76a 
* docs: code samples for `reset_index` and `sort_values`

* fix alignment in dataframe api code samples
@shobsi @Genesis929
docs: code samples for isna, isnull, dropna, isin (#289)
8dab439 
* docs: code samples for `isna`, `isnull`, `dropna`, `isin`

* fix header alignment in rendering
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Dec 26, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Dec 26, 2023
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 27, 2023
@Genesis929 Genesis929 changed the title Fix: Update dataframe.to_gbq to convert non-string column names to st… Fix: Update dataframe.to_gbq to dedup column names. Dec 27, 2023
@Genesis929 Genesis929 marked this pull request as ready for review December 27, 2023 23:51
@Genesis929 Genesis929 requested review from a team as code owners December 27, 2023 23:51
@Genesis929 Genesis929 requested a review from shobsi December 27, 2023 23:51
@Genesis929 Genesis929 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 28, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 746115d into main Dec 28, 2023
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the huanc-gbq-dedup-b306466105 branch December 28, 2023 20:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 28, 2023
@release-please release-please bot mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Genesis929 @shobsi @TrevorBergeron