Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add attempt_direct_path argument to create_channel #583

Merged
merged 19 commits into from
Feb 4, 2024
Merged

feat: Add attempt_direct_path argument to create_channel #583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
421becd
feat: Add attempt_direct_path argument to create_channel
parthea Jan 31, 2024
65b994e
Merge branch 'main' into add-support-for-direct-path
parthea Jan 31, 2024
b1010ea
add more test cases
parthea Jan 31, 2024
9a1957a
fix docstring
parthea Jan 31, 2024
b223b85
fix docstring
parthea Jan 31, 2024
e7e3cf7
update docstring of attempt_direct_path arg
parthea Feb 4, 2024
44d5845
update docstring of target arg
parthea Feb 4, 2024
e6ea7ec
Add comment for dns_prefix local variable
parthea Feb 4, 2024
0f3a0e4
Set the default value of attempt_direct_path to False
parthea Feb 4, 2024
60b8acb
simplify conditional statement
parthea Feb 4, 2024
1a7578d
use warnings.warn instead of _LOGGER.debug
parthea Feb 4, 2024
af3a21b
update docstring of target arg in _modify_target_for_direct_path
parthea Feb 4, 2024
c0052e6
s/direct_path_prefix/direct_path_separator
parthea Feb 4, 2024
d63402e
default->google_auth_default
parthea Feb 4, 2024
396d8fa
parametrize target in def test_create_channel_implicit
parthea Feb 4, 2024
d3598ee
Merge branch 'main' into add-support-for-direct-path
parthea Feb 4, 2024
e9199a0
Add github issue for TODO
parthea Feb 4, 2024
d96499f
filter deprecation warning related to grpcio-gcp
parthea Feb 4, 2024
d41ca10
format docstring
parthea Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set the default value of attempt_direct_path to False
  • Loading branch information
@parthea
parthea committed Feb 4, 2024
commit 0f3a0e4c4e8afa02c3733eb246d548609c47d730
2 changes: 1 addition & 1 deletion google/api_core/grpc_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def create_channel(
default_scopes=None,
default_host=None,
compression=None,
attempt_direct_path: Optional[bool] = None,
attempt_direct_path: Optional[bool] = False,
**kwargs,
):
"""Create a secure channel with credentials.
Expand Down
2 changes: 1 addition & 1 deletion google/api_core/grpc_helpers_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def create_channel(
default_scopes=None,
default_host=None,
compression=None,
attempt_direct_path: Optional[bool] = None,
attempt_direct_path: Optional[bool] = False,
**kwargs
):
"""Create an AsyncIO secure channel with credentials.
Expand Down