Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore support for grpcio-gcp #418

Merged
merged 15 commits into from
Sep 1, 2022
Merged

fix: restore support for grpcio-gcp #418

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e7a7394
fix: restore support for grpcio-gcp
parthea Jul 28, 2022
bf2f2ba
update support date
parthea Jul 28, 2022
ec05a12
Merge branch 'main' into add-grpcio-gcp
parthea Aug 10, 2022
6ab58f1
lint
parthea Aug 10, 2022
4de93c2
Merge branch 'main' into add-grpcio-gcp
parthea Aug 10, 2022
2dd89b6
Merge branch 'main' into add-grpcio-gcp
parthea Aug 30, 2022
74d4d47
fix(deps): require protobuf 3.19.0
parthea Aug 30, 2022
f7dec25
ensure protobuf < 4 for python 3.7 unit test
parthea Aug 30, 2022
996a5cf
only import grpc_gcp if protobuf < 4
parthea Aug 30, 2022
7bd6905
lint
parthea Aug 30, 2022
313cc24
Merge branch 'main' into add-grpcio-gcp
parthea Sep 1, 2022
6225d4f
address review feedback
parthea Sep 1, 2022
5b74ea9
fix(deps): require protobuf >= 3.20.1
parthea Sep 1, 2022
dcbeaa4
fix typo
parthea Sep 1, 2022
08ff43a
properly slice version
parthea Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review feedback
  • Loading branch information
@parthea
parthea committed Sep 1, 2022
commit 6225d4fad49792d88b00584f8c7596c2d02c076c
2 changes: 1 addition & 1 deletion google/api_core/grpc_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
PROTOBUF_VERSION = google.protobuf.__version__

# The grpcio-gcp package only has support for protobuf < 4
if int(PROTOBUF_VERSION.split(".")[0]) < 4:
if PROTOBUF_VERSION == "4.":
try:
import grpc_gcp

Expand Down