-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add kokoro 3.9 configs #175
Conversation
Hey @leahecole, Could we add the configurations to the synthtool templates here? |
See synthtool feature request here. |
On it - thanks for the reference @parthea |
This will probably need a rework to instead specify the build specific project in a noxfile_config |
@parthea I was trying to follow through on my earlier comment and of course forgot what I meant. I added a noxfile_config to the model builder samples directory that calls the BUILD_SPECIFIC_GCLOUD_PROJECT - we define that value with the ucaip project in the kokoro configs. Given that kokoro configs are being sync'd with Owlbot, and we normally do a build specific project as one from our project pool, should I actually be doing this in the noxfile config? What I think we need
What we currently have (which references a project string defined in common.cfg
|
Hey @leahecole , I'm not sure how to solve it with
|
Hey @leahecole, |
That will work and I'm happy to hand it off to you! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@leahecole Done, please can you take a look? |
@parthea other than these little fixes (which very well could have been a copy paste error from me) it looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Because I'm the original author I can't approve so perhaps another @googleapis/python-samples-owners can approve :) |
Thanks @busunkim96 :) |
This will be blocked until
and
Internal CL352076910 adds 3.6, 3.8, and 3.9 internal configs (3.7 is already set up)