Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Update dependency on google-api-core to match other SDK packages #88

Closed
major opened this issue Oct 4, 2021 · 2 comments · Fixed by #89
Closed

Update dependency on google-api-core to match other SDK packages #88

major opened this issue Oct 4, 2021 · 2 comments · Fixed by #89
Assignees
Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@major
Copy link

major commented Oct 4, 2021

Would it be possible to update this package to use a more recently version of google-api-core so that it matches up with other Python Google SDK packages?

Environment details

  • OS type and version: Fedora 36
  • Python version: Python 3.9.7
  • pip version: 21.2.4
  • google-cloud-access-context-manager version: 0.1.7

Steps to reproduce

  1. Install latest version of google-api-core used by most other SDK packages.
  2. Attempt to install this package.

Code example

N/A

Stack trace

N/A

@product-auto-label product-auto-label bot added the api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. label Oct 4, 2021
@tseaver tseaver self-assigned this Oct 4, 2021
@tseaver
Copy link
Contributor

tseaver commented Oct 4, 2021

@major I can reproduce locally:

$ python3.9 -m venv /tmp/acm-88
$ /tmp/acm-88/bin/pip install --upgrade setuptools pip wheel
...
Successfully installed pip-21.2.4 setuptools-58.2.0 wheel-0.37.0
$ /tmp/acm-88/bin/pip install google-api-core
...
Successfully installed cachetools-4.2.4 certifi-2021.5.30 charset-normalizer-2.0.6 google-api-core-2.0.1 google-auth-2.2.1 googleapis-common-protos-1.53.0 idna-3.2 protobuf-3.18.0 pyasn1-0.4.8 pyasn1-modules-0.2.8 requests-2.26.0 rsa-4.7.2 urllib3-1.26.7

and then:

$ /tmp/acm-88/bin/pip install google-cloud-access-context-manager
...
  Attempting uninstall: google-api-core
    Found existing installation: google-api-core 2.0.1
    Uninstalling google-api-core-2.0.1:
      Successfully uninstalled google-api-core-2.0.1
Successfully installed google-api-core-2.0.0 google-cloud-access-context-manager-0.1.7 grpcio-1.41.0 six-1.16.0

This is actually already fixed on the main branch -- we just need a release which includes the fix.

tseaver added a commit that referenced this issue Oct 4, 2021
@tseaver tseaver added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 4, 2021
tseaver added a commit that referenced this issue Oct 4, 2021
@major
Copy link
Author

major commented Oct 4, 2021

@tseaver Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants