Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores(build): add conformance-test to workflow #1176

Merged
merged 2 commits into from
May 3, 2020
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented May 1, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@jkwlui jkwlui requested a review from bcoe May 1, 2020 22:43
@jkwlui
Copy link
Member Author

jkwlui commented May 1, 2020

@bcoe can I get your help taking a look at the workflow config?

I'm not sure at what point in time we stopped running conformance test from CI, so this adds it back in.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #1176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1176   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          12       12           
  Lines       11453    11453           
  Branches      590      525   -65     
=======================================
  Hits        11361    11361           
  Misses         92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e48539...ff7d098. Read the comment docs.

branches:
- master
pull_request:
name: ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably call this something other than CI, perhaps conformance?

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, I think we might want to rename ci to conformance.

@jkwlui jkwlui merged commit f72082d into master May 3, 2020
@jkwlui jkwlui deleted the ci-conformance-test branch May 3, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants