Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

docs(samples): removing migrated samples #985

Merged
merged 24 commits into from
Jan 19, 2023
Merged

docs(samples): removing migrated samples #985

merged 24 commits into from
Jan 19, 2023

Conversation

meredithslota
Copy link
Contributor

Do not merge until SnippetBot is happy.

@meredithslota meredithslota requested review from a team as code owners January 14, 2023 07:00
@generated-files-bot
Copy link

generated-files-bot bot commented Jan 14, 2023

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 14, 2023
@snippet-bot
Copy link

snippet-bot bot commented Jan 14, 2023

Here is the summary of changes.

You are about to delete 31 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: speech Issues related to the googleapis/nodejs-speech API. samples Issues that are directly related to samples. labels Jan 14, 2023
@meredithslota meredithslota added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: speech Issues related to the googleapis/nodejs-speech API. samples Issues that are directly related to samples. size: xl Pull request size is extra large. labels Jan 14, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: speech Issues related to the googleapis/nodejs-speech API. samples Issues that are directly related to samples. labels Jan 14, 2023
@meredithslota
Copy link
Contributor Author

Sent cl/502075743 to update sample locations as samples have moved.

@meredithslota
Copy link
Contributor Author

Submitted cl/502075743, now just waiting for the SnippetBot index to update with whether any remaining samples are linked in docs.

@meredithslota meredithslota removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 17, 2023
@meredithslota
Copy link
Contributor Author

SnippetBot is now happy, removing the do not merge label. Samples test is still failing, will look into this.

@meredithslota
Copy link
Contributor Author

Reverted changes to quickstart.js and testing as that is used by the library.

@sofisl sofisl merged commit 0cd69c5 into main Jan 19, 2023
@sofisl sofisl deleted the delete-samples branch January 19, 2023 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: speech Issues related to the googleapis/nodejs-speech API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants