Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example for Table.upsert() #533

Merged
merged 2 commits into from Feb 19, 2019
Merged

Fixed example for Table.upsert() #533

merged 2 commits into from Feb 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 19, 2019

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@30db9ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #533   +/-   ##
=========================================
  Coverage          ?   89.76%           
=========================================
  Files             ?       15           
  Lines             ?     1417           
  Branches          ?       42           
=========================================
  Hits              ?     1272           
  Misses            ?      140           
  Partials          ?        5
Impacted Files Coverage Δ
src/table.ts 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30db9ae...a613353. Read the comment docs.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@callmehiphop callmehiphop merged commit 90f2388 into googleapis:master Feb 19, 2019
@callmehiphop
Copy link
Contributor

Thanks for the fix @sulaysumaria!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants