Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Spanner region tags. #136

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Clean up Spanner region tags. #136

merged 2 commits into from
Mar 1, 2018

Conversation

@jmdobry jmdobry requested a review from stephenplusplus March 1, 2018 01:18
@ghost ghost assigned jmdobry Mar 1, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2018
@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2857101). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #136   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     11           
  Lines             ?   1257           
  Branches          ?      0           
=======================================
  Hits              ?   1257           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/database.js 100% <ø> (ø)
src/instance.js 100% <ø> (ø)
src/table.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2857101...7b142e3. Read the comment docs.

@ghost ghost assigned stephenplusplus Mar 1, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 1, 2018
@stephenplusplus stephenplusplus merged commit 04283e8 into master Mar 1, 2018
@jmdobry jmdobry changed the title Cleanup Spanner region tags. Clean up Spanner region tags. Mar 1, 2018
@jmdobry jmdobry deleted the spanner-cleanup branch March 1, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants