fix: set instanceId to the given id #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a display name was given, we were setting the instanceId to the display name. This is a bug. Fixes googleapis#1093
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 21 21
Lines 20602 20602
Branches 1109 1109
=======================================
Hits 20247 20247
Misses 352 352
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a display name was given, we were setting the instanceId to the display name. This is a bug.
Fixes #1093