Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance can't be created unless instanceId == displayName #1093

Closed
skuruppu opened this issue Jun 11, 2020 · 0 comments · Fixed by #1094
Closed

Instance can't be created unless instanceId == displayName #1093

skuruppu opened this issue Jun 11, 2020 · 0 comments · Fixed by #1094
Assignees
@skuruppu
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@skuruppu
Copy link
Contributor

While working on #1073, I came across an issue where I was trying to set the displayName on a CreateInstance request where the displayName was different to the instanceId. I kept getting the error ERROR: { Error: 3 INVALID_ARGUMENT: Invalid CreateInstance request. }.

Turns out there's a bug in the wrapper around CreateInstance that sets the instanceId to displayName.
@skuruppu skuruppu added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jun 11, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jun 11, 2020
skuruppu added a commit to skuruppu/nodejs-spanner that referenced this issue Jun 11, 2020
@skuruppu
fix: set instanceId to the given id
495e4c8 
Previously if a display name was given, we were setting the instanceId
to the display name. This is a bug.

Fixes googleapis#1093
@skuruppu skuruppu mentioned this issue Jun 11, 2020
Merged
@skuruppu skuruppu self-assigned this Jun 11, 2020
skuruppu added a commit that referenced this issue Jun 11, 2020
@skuruppu
fix: set instanceId to the given id (#1094)
8973cbc 
Previously if a display name was given, we were setting the instanceId
to the display name. This is a bug.

Fixes #1093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skuruppu skuruppu

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set instanceId to the given id skuruppu/nodejs-spanner
1 participant
@skuruppu