Skip to content

Commit

Permalink
build: fix path-to-regexp (#2108)
Browse files Browse the repository at this point in the history
Sinon having dependency on the [nise package](https://www.npmjs.com/package/nise). That package just published v6.0.1 which updated path-to-regexp from v6.2.1 to v8.1.0 with https://github.com/sinonjs/nise/pull/226. That should have been a major version bump, as this ended up introducing a breaking change that now it depends on Node >= 16, which is causing our CI to break.

This PR fixes path-to-regexp to ^6.2.1 like previously to make it work on Node >= 14
  • Loading branch information
alkatrivedi authored Sep 12, 2024
1 parent 992baaa commit a0ef202
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ system-test/*key.json
.DS_Store
package-lock.json
__pycache__
.vscode
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,10 @@
"mocha": "^9.2.2",
"mv": "^2.1.1",
"ncp": "^2.0.0",
"nise": "6.0.0",
"@opentelemetry/sdk-trace-node": "^1.25.1",
"p-limit": "^3.0.1",
"path-to-regexp": "6.2.2",
"proxyquire": "^2.0.1",
"sinon": "^18.0.0",
"stats-lite": "^2.1.1",
Expand Down

0 comments on commit a0ef202

Please sign in to comment.