Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: modernize mocha config #875

Merged
merged 14 commits into from
Mar 29, 2020
Merged

test: modernize mocha config #875

merged 14 commits into from
Mar 29, 2020

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2020
@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #875 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
- Coverage   83.63%   83.59%   -0.04%     
==========================================
  Files          31       31              
  Lines       11390    11390              
  Branches      384      367      -17     
==========================================
- Hits         9526     9522       -4     
- Misses       1863     1867       +4     
  Partials        1        1              
Impacted Files Coverage Δ
src/message-stream.ts 97.69% <0.00%> (-0.77%) ⬇️
src/subscriber.ts 99.36% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bd91c...42b0421. Read the comment docs.

@JustinBeckwith JustinBeckwith added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2020
@bcoe bcoe added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2020
@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@bcoe bcoe added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Mar 2, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@bcoe bcoe added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Mar 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@feywind
Copy link
Collaborator

feywind commented Mar 4, 2020

I think there might actually be an issue here (or uncovered issues from the upgrade). I'll look at this a bit later.

@feywind
Copy link
Collaborator

feywind commented Mar 27, 2020

Looks like the same failure here as #875.

@JustinBeckwith JustinBeckwith merged commit d4cba53 into master Mar 29, 2020
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
d4cba53
commit d4cba53
Author: Justin Beckwith <[email protected]>
Date:   Sun Mar 29 15:09:44 2020 -0700

    test: modernize mocha config (#875)
@stephenplusplus stephenplusplus deleted the mocharc branch August 10, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants